rusackas commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3973273110
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -70,6 +72,9 @@ export default function exportPivotExcel(
logging.error(
`[exportPivotExcel] No element found for selector: "${tableSelector}"`,
);
+ addWarningToast(
Review Comment:
Good catch, that was calling the raw action creator with no dispatch, so it
never rendered anything. Fixed in 5d8e91b: `exportPivotExcel` now takes an
optional bound toast callback, and both call sites wire it up via `useToasts()`
(explore menu) or the existing `bindActionCreators` block (dashboard
`Chart.tsx`), same pattern already used there for
`addSuccessToast`/`addDangerToast`. Added a test for the no-callback case too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
