jansule commented on issue #33900: URL: https://github.com/apache/superset/issues/33900#issuecomment-5598180289
Good points @rusackas For the cartodiagram, consistent color to label mapping across the different charts is crucial - anything else would be prone to misinterpretation of the provided information. I can imagine this might differ for other charts using subcharts, though. I don't have a strong opinion on whether those labels should be persisted on the dashboard's `map_label_colors`. There, I would follow the common approach in superset for consistence. > And is there a sane way for a parent chart to hand a scale down into a child's transformProps, rather than the plugin copying the echarts label formatting just to register labels ahead of time? Handing down a scale to a chart's children would be the cleanest approach, I think, leading to stronger decoupling and less code duplication. This also allows for the most flexibility with every parent chart deciding on the behavior on how scales will be created. So through this, we should be able to cover both scenarios consistent color mapping across subcharts as well as independent color mapping. We might run into problems depending on how subcharts handle the creation of the scales and it's behavioral consistency across different charts. I don't have enough knowledge of the other charts to clearly see whether that is something we actually have to consider, but I'm sure you do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
