rusackas commented on issue #33900: URL: https://github.com/apache/superset/issues/33900#issuecomment-5647646360
@jansule took a look at other subchart-composing plugins — deck.gl's `Multi` layer (`preset-chart-deckgl`) calls other charts' `transformProps` the same way cartodiagram does, via `getChartTransformPropsRegistry`, but it doesn't touch color scales itself. So there's no existing precedent for scale coordination to lean on, but it also means a `superset-ui-core` API for handing a scale into a child's `transformProps` wouldn't be a first-of-its-kind change for the plugin ecosystem. That's the direction I'd most likely prefer over duplicating echarts label logic in the plugin, though if there's a counterpoint, I'm open to discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
