uyivzola commented on PR #43182:
URL: https://github.com/apache/superset/pull/43182#issuecomment-5607049415

   Tested `52f9ec5` on ARM64 with `DEV_MODE=false`. The `lean`, `dev`, and `ci` 
builds passed, but I found two regressions:
   
   - Removing `libecpg-dev` also removes `ecpg`, which PostgreSQL validation 
uses through pgsanity. Both `SELECT 1` and invalid SQL raise `OSError: Unable 
to execute 'ecpg'`; validation works on the parent commit.
   - The `py311`/`py312` presets use Bookworm, where installing `libldap2` 
fails. That release needs `libldap-2.5-0`.
   
   I prepared a [follow-up 
commit](https://github.com/uyivzola/superset/commit/6d10fd43e4f0f04a2bfc56ace53d50cc2f6dd996)
 on top of this head: copy only `ecpg` from a matching build stage, select the 
LDAP package by Debian release, and check SQL validation in Docker CI.
   
   With the patch, ARM64 `lean`/`dev`/`ci` and both Bookworm presets build 
successfully. Valid/invalid SQL tests pass; lean images still contain no `-dev` 
packages. PostgreSQL/Redis initialization, login, health, generated assets, and 
queries passed too. Native LDAP/MySQL/PostgreSQL imports and linkage passed.
   
   AMD64 and live LDAP/MySQL authentication were not tested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to