rusackas commented on PR #43182: URL: https://github.com/apache/superset/pull/43182#issuecomment-5647549159
@bikash-barnwal @uyivzola's test above found real regressions: dropping `libecpg-dev` (Dockerfile line 21) also drops the `ecpg` binary, and `pgsanity` (a `requirements/base.txt` runtime dep used by `superset/sql_validators/postgres.py`) needs it for Postgres SQL validation — that'll break in the `lean` image. `libldap2` also doesn't exist on the Bookworm-based py311/py312 presets, only trixie. They posted a follow-up commit with fixes for both plus a Docker CI check for SQL validation — worth pulling in before this merges. hainenber's changes-requested is also still standing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
