rusackas commented on code in PR #42941:
URL: https://github.com/apache/superset/pull/42941#discussion_r3972986569
##########
superset-frontend/plugins/plugin-chart-country-map/src/transformProps.ts:
##########
@@ -64,6 +67,7 @@ export default function transformProps(chartProps:
ChartProps) {
? { country_id: row[entityLabel], metric: row[metricLabel] }
: row,
);
+ const formatters = getColorFormatters(conditionalFormatting, data, theme);
Review Comment:
This got covered in 5d0008e1f52 ("add a test and a small fix") - there's now
a test asserting `transformed.formatters` from `getColorFormatters`, plus one
for the empty case. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
