bito-code-review[bot] commented on code in PR #42941:
URL: https://github.com/apache/superset/pull/42941#discussion_r3972987791
##########
superset-frontend/plugins/plugin-chart-country-map/src/transformProps.ts:
##########
@@ -64,6 +67,7 @@ export default function transformProps(chartProps:
ChartProps) {
? { country_id: row[entityLabel], metric: row[metricLabel] }
: row,
);
+ const formatters = getColorFormatters(conditionalFormatting, data, theme);
Review Comment:
<!-- Bito Reply -->
The suggestion to add test coverage for the new formatters is appropriate.
Since the code now includes a test asserting the `transformed.formatters`
output, the concern raised by the reviewer has been addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
