aminghadersohi commented on PR #44106: URL: https://github.com/apache/superset/pull/44106#issuecomment-5612591399
@gabotorresruiz Thanks for the review! Addressed the NIT in b44a38d93d: missing dotted dimensions are named together and the shared nested-field recovery guidance is emitted once. Single-dimension wording is unchanged. Extended `test_query_dataset_unregistered_dimension_is_actionable` with two missing dotted dimensions and a mixed dotted/non-dotted case, asserting every missing name is reported, each guidance fragment occurs exactly once, and no query executes. Both new cases failed before the fix; all 65 tests in the file pass afterward. Updated the documentation note, and `uvx pre-commit run --files` passes for all three changed files (including mypy, Ruff, and pylint). The metadata access boundary is unchanged. Leaving the PR in draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
