aminghadersohi commented on PR #44106: URL: https://github.com/apache/superset/pull/44106#issuecomment-5623335026
Rebased onto `master` (b20ad09391) and resolved the two conflicts: - `docs/admin_docs/configuration/mcp-server.mdx` — both sides appended a new section at the same anchor. Kept master's `### Reporting query dates` (from #44105) and this PR's `## Dataset query dimensions and nested fields` after it. - `tests/unit_tests/mcp_service/dataset/tool/test_query_dataset.py` — both sides appended independent test functions at end of file. Kept both sets. Both were additive collisions, so nothing was dropped: the diff against master is unchanged at 219 insertions across the same 3 files. The full file now runs 102 passed, 1 skipped (up from 65 — master's new time-bounds tests now coexist with these), and `uvx pre-commit run --files` passes on all three changed files. @gabotorresruiz the NIT was already addressed in the prior push and survives the rebase: missing dotted dimensions are named together and the shared nested-field guidance is emitted once, with singular/plural agreement on the verb. Single-name wording is unchanged. PR is now MERGEABLE. Left in draft, as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
