drivaspreset commented on PR #43004: URL: https://github.com/apache/superset/pull/43004#issuecomment-5622317255
This PR's GAQ Playwright coverage looks different from earlier revisions — 2 test cases were removed and 1 new one was added. Wanted to explain why, since it's a deliberate consequence of the Global Task Framework migration, not a coverage regression. What was dropped: the two "async-token cookie" tests — - a chart-data submission without the async-channel token is rejected with 401 - a 401 from chart-data bounces the user off the dashboard, and the session survives it Why this isn't a bug: the mechanism these tests exercised no longer exists. The old GAQ implementation validated a private async-token httponly cookie (identifying the caller's channel) in ChartDataRestApi._run_async before accepting a job, rejecting with 401 if it was missing/lost — that's exactly what these two tests were probing. #43407 deleted that entire channel/token system as part of moving GAQ onto the Global Task Framework: superset/async_events/, the /api/v1/async_event/ endpoint, and the async-token cookie are all gone. Confirmed independently (not just from the migration's own commit message): There's no 401-on-missing-token path left for a test to exercise, so removing these was forced by the architecture change. What replaced them: a programmatic chart-data request stays synchronous unless it opts into async_mode — covering the contract that took over. Under GTF, enabling the feature flag only makes async available; each request opts in via an async_mode field (default false). This test proves a client that doesn't set it gets the plain synchronous 200 flow even on a GAQ-enabled deployment, replaying the app's real payload with async_mode stripped and force: true so a 200 means the query genuinely ran inline rather than being served from a warm cache. cc @sadpandajoe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
