sadpandajoe commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r3985068763
##########
.github/workflows/superset-playwright.yml:
##########
@@ -153,6 +153,30 @@ jobs:
INCLUDE_MOBILE: "true"
with:
run: playwright-run "${{ matrix.app_root }}" mobile/
+ - name: Run Playwright (Global Async Queries Tests)
Review Comment:
This step inherits `if: success()`, so any failure in the preceding
Experimental or Mobile step skips GAQ entirely and leaves no coverage for that
commit. Should GAQ run in its own job or otherwise be conditioned to run
independently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
