bito-code-review[bot] commented on PR #43914: URL: https://github.com/apache/superset/pull/43914#issuecomment-5624714181
<!-- Bito Reply --> Extending existing unit tests is a valid approach to keep the test suite compact. Given that the new file `tests/unit_tests/common/test_tabular_query_cache_key.py` focuses on testing `QueryObject.cache_key` behavior, you could integrate these test cases into an existing test file that covers `QueryObject` or `cache_key` logic, such as `tests/unit_tests/common/test_query_object.py` if it exists, or a similar module. This would consolidate the testing logic for `QueryObject` and avoid adding new files to the repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
