shivamgoel commented on PR #43914: URL: https://github.com/apache/superset/pull/43914#issuecomment-5624991183
Moved both assertions into `query_object_test.py` next to the existing `cache_key` tests and dropped the new file; the other two cases were already covered by `test_apply_granularity_with_granularity_in_temporal_filters` and `test_no_filter_time_range`. On semantic vs legacy — single path: `query_cache_key` → `QueryObject.cache_key` for both, with `SqlaTable`/`SemanticView` only contributing `get_extra_cache_keys`. Parametrizing by datasource type would cover identical lines, so I left it out; happy to add if you'd prefer it explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
