aminghadersohi commented on PR #44152: URL: https://github.com/apache/superset/pull/44152#issuecomment-5636000629
## Maintainer pass complete — required CI green Head: **b9d213c4d4ce9e6b5d03c6ea3e706caf7a41d799** (normal push). - Accept finite Decimal/real Treemap metrics; continue rejecting booleans and nonfinite results. - Align saved/form-data-key preview queries with the configured row limit. - Serialize currency settings with native symbolPosition. - Preserve saved predicates and neutral temporal bindings when adding filters with temporal_column omitted; honor explicit clears and safe rebinds. - Reverify type-distinct geometry, native request validation, temporal query selection and containment of genuine Pydantic resolution errors through registered FastMCP calls. Validation: - **273 focused tests passed**, including public previews, updates and data/export paths. - Exact-head MCP/common run: **4,459 passed, 1 skipped** (optional BigQuery dependency), in 326.05 seconds. SQL **1,717 passed / 100% coverage** and semantic layers **437 passed / 100% coverage**. - **31 regression cases fail on the prior head**; the strengthened cases pass after these fixes. - Real Vega/Vega-Lite rendering, branch-file pre-commit (MyPy/Ruff/Pylint/format/workflow audit), compile and diff checks passed. - [Exact-head CI](https://github.com/apache/superset/actions/runs/34606901158): **all 13 required checks passed**. Overall: **65 success, 10 skipped, 2 neutral**, no pending/failing checks. - Python-Unit finished in **31m44s**: **15,277 passed, 7 skipped, 2 xfailed**; SQL **1,717 / 100% coverage**, semantic layers **437 / 100% coverage**; coverage and JUnit uploads passed. - No retries were needed. No coverage thresholds, tests, required gates or timeout budgets were weakened. - Individual evidence replies were posted on all eight threads; **all eight are resolved** after final verification. A final fetch found no additional actionable threads. Pydantic inheritance and native-adapter ordering claims were disproved with actual public-path regressions, not assumed fixed from earlier replies. PR remains Amin-authored/assigned, non-draft, unmerged and conflict-free (MERGEABLE). Human approval is still required (REVIEW_REQUIRED). Worktree is clean. Local live Superset/database/browser validation is unavailable; registered product-path tests mock query execution and persistence; exact-head integration/browser CI passed. The existing real Vega/Vega-Lite renderer regressions ran locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
