aminghadersohi commented on PR #44152: URL: https://github.com/apache/superset/pull/44152#issuecomment-5639428055
Finite maintainer check on unchanged head **b9d213c4d4ce9e6b5d03c6ea3e706caf7a41d799**. Regarding the [row-limit/renderer advisory](https://github.com/apache/superset/pull/44152#issuecomment-5637814806): the query bound and geometry bound intentionally differ. A configured limit above 1,000 does **not** itself reject a preview; the renderer checks the number of rows actually returned. The existing documentation explicitly limits geometry to 1,000 rows and promises UnsupportedTreemapPreview for oversized results. Reproduced through registered get_chart_preview calls for saved, saved-cache and unsaved-cache paths, with row_limit=1001/10000 and actual results of 1000/1001 rows: - The query keeps the configured row limit in every case. - 1,000 returned rows produce rect geometry containing every leaf. - 1,001 returned rows produce the declared UnsupportedTreemapPreview, with no substitute or silently truncated geometry. The 12 temporary public-path boundary probes plus existing oversized-geometry and real Vega renderer regressions all passed: **18 passed**. Temporary probes were removed; no repository files changed. Capping the query at 1,000 would hide categories present in the chart; raising the geometry bound would change the documented bounded-preview contract. Neither change is appropriate for this advisory. All eight review threads remain resolved; no new unresolved thread or material defect was found. All **13 required exact-head checks are green**. PR remains non-draft, conflict-free and awaiting human approval (REVIEW_REQUIRED). No commit/push, retry, draft, merge, or acceptance-zone move was made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
