FrancescoCastaldi commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r3993418204
##########
superset/db_engine_specs/databricks.py:
##########
@@ -629,9 +657,22 @@ class
DatabricksNativeEngineSpec(DatabricksDynamicBaseEngineSpec):
"databricks+connector://token:{access_token}@{host}:{port}/{database_name}"
)
- # Note: Primary metadata is in DatabricksPythonConnectorEngineSpec which
- # consolidates all Databricks connection methods. This spec exists for
- # backwards compatibility with legacy databricks-dbapi connections.
+ metadata = {
+ "description": ("Databricks legacy connector using databricks-dbapi."),
+ "logo": "databricks.png",
+ "homepage_url": "https://www.databricks.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
+ ],
+ "pypi_packages": ["databricks-dbapi[sqlalchemy]"],
Review Comment:
Updated DatabricksNativeEngineSpec metadata to specify
\[\databricks-sql-connector\, \databricks-sqlalchemy\]\, the \databricks://\
URI scheme supported under SQLAlchemy 2.0, and updated the description
accordingly.
##########
superset/db_engine_specs/kusto.py:
##########
@@ -209,15 +209,41 @@ def convert_dttm(
class KustoKqlEngineSpec(BaseEngineSpec): # pylint: disable=abstract-method
- """Azure Data Explorer engine spec using native KQL query language.
-
- Note: Documentation is consolidated in KustoSqlEngineSpec (Azure Data
Explorer).
- This spec exists for runtime support of the kustokql driver.
- """
+ """Azure Data Explorer engine spec using native KQL query language."""
engine = "kustokql"
engine_name = "Azure Data Explorer (KQL)"
time_groupby_inline = True
+
+ metadata = {
+ "description": (
+ "Azure Data Explorer (Kusto) using native Kusto Query Language
(KQL) "
+ "for fast, exploratory telemetry and log analytics."
+ ),
+ "logo": "kusto.png",
+ "homepage_url":
"https://azure.microsoft.com/en-us/products/data-explorer/";,
+ "categories": [
+ DatabaseCategory.CLOUD_AZURE,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.PROPRIETARY,
+ ],
+ "pypi_packages": ["sqlalchemy-kusto"],
Review Comment:
Added the matching \known_incompatibilities\ entry to
\KustoKqlEngineSpec.metadata\ with a dedicated unit test in \ est_kusto.py\.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
