FrancescoCastaldi commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-5640677242
Pushed commit with all requested adjustments:
- **IBM i**: Reverted connection string to the driver-supported no-port URI
(`ibmi://{username}:{password}@{host}/{database}`) and omitted `default_port`
and port parameter. Updated `test_ibmi.py`.
- **Arc**: Updated `default_port` to `8000` to match `arc-superset-arrow`
defaults. Updated `test_arc.py`.
- **Databricks**: Pointed `DatabricksNativeEngineSpec.metadata` to
`["databricks-sql-connector", "databricks-sqlalchemy"]`, the `databricks://`
URI scheme supported under SQLAlchemy 2.0, and updated the description.
- **Kusto (KQL)**: Added `known_incompatibilities` to
`KustoKqlEngineSpec.metadata` matching the SQL variant, with test coverage in
`test_kusto.py`.
- **Aurora PostgreSQL (Data API)**: Omitted `default_port` from
`AuroraPostgresDataAPI.metadata` to match Data API architecture and the sibling
MySQL Data API spec.
- **ODPS Tests**: Removed unused `monkeypatch` test fixture parameter in
`test_odps.py`.
All checks verified with `lint_metadata.py` and `ruff`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
