aminghadersohi commented on code in PR #44171:
URL: https://github.com/apache/superset/pull/44171#discussion_r3990973221
##########
superset/mcp_service/server.py:
##########
@@ -696,7 +696,8 @@ async def call_tool(
if name in {transform._call_tool_name,
transform._search_tool_name}:
raise ToolError(
f"'{name}' is a synthetic search tool and cannot be "
- f"called via the call_tool proxy"
+ f"called via the call_tool proxy",
+ log_level=logging.WARNING,
Review Comment:
nit: measured on fastmcp 3.4.7 this path logs `Error calling tool
'call_tool'` — and the proxy's outer frame re-emits that same message at ERROR
whenever any *target* routed through it fails. Sentry groups on the message, so
expect volume reduction, not the issue closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
