bito-code-review[bot] commented on PR #44171:
URL: https://github.com/apache/superset/pull/44171#issuecomment-5637122154
<!-- Bito Reply -->
The change in this PR explicitly addresses the issue where `ToolError`
exceptions were being logged at the default `ERROR` level, causing them to be
captured by Sentry. By setting `log_level=logging.WARNING` in the `ToolError`
raised for synthetic tool names, the intention is to prevent these expected
400-class errors from triggering Sentry alerts, as confirmed by the added unit
test `test_call_tool_proxy_rejects_synthetic_names_with_warning_log_level`.
**superset/mcp_service/server.py**
```
raise ToolError(
f"'{name}' is a synthetic search tool and cannot be "
f"called via the call_tool proxy",
log_level=logging.WARNING,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
