rusackas commented on PR #43136: URL: https://github.com/apache/superset/pull/43136#issuecomment-5647738329
The fix itself looks solid, hyphen case is covered with tests now too. This is stacked on #42805 though, so we can't really merge it standalone until that one lands. Fine to leave the retention thread open since it's tracked on the parent already. Thanks for all the PRs, we'll try to get through the pile in good time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
