bito-code-review[bot] commented on PR #44216:
URL: https://github.com/apache/superset/pull/44216#issuecomment-5656006695
<!-- Bito Reply -->
The flagged issue is correct. Hardcoding `zIndex: theme.zIndexBase` in
`PopoverDropdown` overrides the default Ant Design popup z-index, which can
cause the dropdown to appear behind other elements.
To resolve this, you should allow the `zIndex` to be configurable or rely on
Ant Design's default z-index management instead of forcing a base level. Since
the PR already adds `overlayStyle` as a prop, you can improve the
implementation by making `zIndex` optional or allowing it to be overridden by
the consumer.
Would you like me to fetch all other comments on this PR to validate them
and implement a comprehensive fix?
**superset-frontend/packages/superset-ui-core/src/components/PopoverDropdown/index.tsx**
```
overlayStyle={{
zIndex: theme.zIndexBase,
...overlayStyle,
}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
