bito-code-review[bot] commented on PR #44068: URL: https://github.com/apache/superset/pull/44068#issuecomment-5660466872
<!-- Bito Reply --> Adding a unit test case that explicitly sets `rowcount` and `sql_rowcount` to different values is a good approach to prevent regressions in the multi-query branch. You can extend the existing test suite in `superset-frontend/src/components/Chart/DrillBy/useResultsTableView.test.ts` by mocking the hook's response to return these distinct values and asserting that the component handles them correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
