EnxDev commented on code in PR #44068:
URL: https://github.com/apache/superset/pull/44068#discussion_r4002972053
##########
superset-frontend/src/components/Chart/DrillBy/useResultsTableView.tsx:
##########
@@ -48,7 +48,7 @@ export const useResultsTableView = (
<SingleQueryResultPane
colnames={chartDataResult[0].colnames}
coltypes={chartDataResult[0].coltypes}
- rowcount={chartDataResult[0].sql_rowcount}
+ rowcount={chartDataResult[0].rowcount}
Review Comment:
Could we add a focused unit assertion here with `rowcount` and
`sql_rowcount` deliberately set to different values?
`useResultsTableView.test.ts` already covers this hook, and the regression is
easy to reintroduce because both fields exist on the response. It would be
useful to cover both the single- and multi-query branches changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
