geido commented on PR #44144: URL: https://github.com/apache/superset/pull/44144#issuecomment-5666856450
Final narrowed-scope validation for `25ec992b1f` (this supersedes the earlier validation comment for the broader implementation): - Exact-`master` Docker reproduction: a below-fold chart backed by a 45-second query was reported `Updated` after ~13 seconds and served an 11,337-byte PNG containing a loading spinner. - Same fixture on this commit: both standard and tiled capture transitioned `Pending` → `Computing` → `Error` after the 30-second readiness budget, logged the chart as `waiting_on_database`, aborted before cache delivery, and returned 404 for the artifact. - Positive Docker matrix: valid PNG/PDF output for empty and chart-free dashboards, in-grid/nested/non-first top-level tabs, four-tile capture, Word Cloud, DeckGL single/multi, Point Cluster, and Cartodiagram. - Real UI path: Chromium selected the non-first top-level tab and used Download → Download as Image; the resulting 1600×1200 PNG contained the correct completed chart. - Compatibility/race checks: a forced refresh retained the previous URL as HTTP 200 before/during/after generation; eight simultaneous forced requests produced one enqueue, seven observers, one shared generation, and a valid terminal artifact. - Local gates: 209 focused unit tests and 20 API integration tests passed; staged pre-commit and regenerated OpenAPI drift checks passed. - Final-SHA CI: full Python unit/coverage, SQLite/PostgreSQL/MySQL integration, pre-commit, frontend, standard and experimental Playwright, Docker builds, OpenAPI, CodeQL, dependency, translation, App CLI, and Presto/Hive checks passed. The final diff changes no frontend or visualization-plugin code and keeps the existing request shape, Celery task signature, status values, and `202`-enqueue/`200`-observer convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
