geido commented on PR #44144: URL: https://github.com/apache/superset/pull/44144#issuecomment-5677412180
Post-review validation for `a55d5eb89c`: - Rebased and squashed onto `ae240a8e6f`; the two conflicts were reconciled with master's report fail-closed capture changes. The PR is mergeable and has zero unresolved review threads. - Human review: fixed the expired-pointer generation-key collision with a UUID successor and an exact split-TTL regression. - Bot review: fixed per-region blank combined captures, the retry deadline reset, and cache-read compatibility; retained the zero-holder and missing-payload recovery behavior after code/E2E validation. The Bito pass reported zero actionable findings; all five advisories were individually assessed. - Local gates: staged pre-commit passed; 214 focused unit tests passed; all 20 relevant dashboard screenshot API integration tests passed on a fresh SQLite/Redis environment; OpenAPI regenerated without drift. - Rebuilt Docker E2E passed tiled and standard PNG/PDF capture for empty/chart-free, in-grid/nested/top-level non-first tabs, multi-tile dashboards, Word Cloud, DeckGL single/multi, Point Cluster, and Cartodiagram. Slow charts failed closed as `Error` with artifact 404; forced refresh preserved the prior artifact; eight concurrent force callers coalesced to one generation. The actual UI export path passed for a non-first tab in both PNG and PDF. - Final-SHA CI passed pre-commit, the complete Python unit suite and strict 100%-coverage subset, OpenAPI drift, frontend build, production Docker builds, CodeQL, dependency/license, translations, and extension checks. The remaining CI failures are an upstream `master` setup failure: `superset db upgrade` sees migration heads `c7f53d184ea2` and `88a01c781622`, so database/browser/dev-Docker jobs stop before tests run. This branch changes no migrations or workflows, and local master reproduced the same failure. The direct upstream repair is #44288; after it merges, this PR can be rebased to obtain a clean CI rerun. The narrowed diff changes no frontend or visualization-plugin code and preserves the public request shape, task signature, status values, `202`-enqueue/`200`-observer convention, and previous forced-refresh download URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
