sfirke opened a new pull request, #44244:
URL: https://github.com/apache/superset/pull/44244
### SUMMARY
Follow-up to #43028, which removed Selenium support and made Playwright with
Chromium the only screenshot backend. A few messages and comments still
referred to Selenium (or Cypress) and can mislead operators:
- `superset/utils/webdriver.py`: the hint appended to the `Playwright is
required for screenshots.` error said "To complete the migration from Cypress
and enable WebGL/DeckGL screenshot support". It now just says how to install
Playwright and Chromium.
- `superset/config.py`:
- the thumbnail comment claimed rendering falls back to a "Selenium user"
for anonymous users (that user was replaced by executors in #31844);
- the `SCREENSHOT_LOCATE_WAIT` comment referred to Selenium;
- a note says `SCREENSHOT_SELENIUM_HEADSTART` and
`SCREENSHOT_SELENIUM_ANIMATION_WAIT` apply to Playwright despite their names.
The keys are not renamed, so existing configs keep working.
- `superset/utils/screenshots.py`: a comment and the `Selenium image size`
debug log.
- `superset/mcp_service/README.md`: remove `WEBDRIVER_TYPE = 'chrome'` from
both sample configs. That key was removed in #43028.
- `docker-compose.yml`: the worker memory-limit comment.
Apart from the wording of that one error message and one debug log line,
there are no behavior changes.
Related: #44243 fixes the same references in the docs. A separate
master-only PR removes the unused `INCLUDE_FIREFOX` build arg and other dead
config.
**Cherry-pick:** this is text-only and a candidate for 7.0, so the install
error shown on 7.0.x deployments without Playwright is accurate.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Error raised when Playwright or Chromium is unavailable:
Before:
```
Playwright is required for screenshots. To complete the migration from
Cypress and enable WebGL/DeckGL screenshot support, install Playwright with:
pip install playwright && playwright install chromium
```
After:
```
Playwright is required for screenshots. Install Playwright and Chromium
with: pip install playwright && playwright install chromium
```
### TESTING INSTRUCTIONS
- `pytest tests/unit_tests/utils/webdriver_test.py
tests/unit_tests/utils/test_screenshot_cache_fix.py` (the only test touching
`PLAYWRIGHT_INSTALL_MESSAGE` checks that it is a string).
- Optional: in an environment without Playwright installed, trigger a report
or thumbnail screenshot and confirm the worker error uses the new wording.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
---
🤖 _Drafted by Claude Code, co-signed by @sfirke._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
