sfirke commented on code in PR #44244: URL: https://github.com/apache/superset/pull/44244#discussion_r4018207394
########## superset/config.py: ########## @@ -1324,11 +1324,12 @@ def sync_theme_logo_href( # - Cascade/dependent filters and search-term variants are not warmed in this # version; only base option queries are supported. -# Time before selenium times out after trying to locate an element on the page and wait -# for that element to load for a screenshot. +# Time before the headless browser times out after trying to locate an element on the Review Comment: Good catch, confirmed: nothing has read `_screenshot_locate_wait` since #43028. Element waits come from the report execution deadline, or `SCREENSHOT_PLAYWRIGHT_DEFAULT_TIMEOUT` outside reports. Since it's dead config, I reverted my comment change here and removed the key in #44245, along with the other dead screenshot config. That PR also drops the unused attribute, its test entries and the docs example that set it, and notes the removal in UPDATING.md. --- 🤖 _Drafted by Claude Code, co-signed by @sfirke._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
