mikebridge opened a new pull request, #44263: URL: https://github.com/apache/superset/pull/44263
### SUMMARY Regression test only — no code change. Pins the fix for SC-120967: an MCP `get_table` on a semantic view served cached results across different `time_range` values (a second request with the same filters but a different range was handed the first range's rows). **Root cause / why no code change:** `get_table`'s `build_query_dict` (`superset/common/tabular_query.py`) expresses `time_range` only as a `TEMPORAL_RANGE` filter — it never sets `QueryObject.time_range`. `QueryContextFactory` resolves that filter to `from_dttm`/`to_dttm` and `_apply_granularity` drops the granularity-column temporal filter, so the resolved bounds are the only thing distinguishing one range's cache key from another's. Before **#43914** (`412ab43712`, merged 2026-09-10) `QueryObject.cache_key` dropped `from_dttm`/`to_dttm` **unconditionally**, so every range collided. #43914 keeps the bounds when `time_range` is unset — which already fixes this on master. This PR just locks the exact `get_table` scenario by name so it can't silently regress. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — test only. ### TESTING INSTRUCTIONS ```bash pytest tests/unit_tests/common/test_tabular_query.py -q # 33 passed ``` Two new tests in `tests/unit_tests/common/test_tabular_query.py`: - `test_get_table_cache_key_distinguishes_time_ranges` — two builds through `build_query_dict` (the view path), same filters, different range → different cache keys. - `test_get_table_cache_key_collides_when_bounds_dropped` — control: with the resolved bounds removed (the pre-#43914 behavior) the two otherwise-identical requests collapse to one key. Verified the control the other way too: reverting #43914's condition in `cache_key` (dropping the bounds unconditionally) makes `test_get_table_cache_key_distinguishes_time_ranges` fail, confirming the test guards that fix. ### ADDITIONAL INFORMATION - [x] Has associated issue: SC-120967 (root-caused to #43914; demo core `89964b2a` predates that fix) - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01C7U5oFfrqUyM6hJTZiW2uf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
