bito-code-review[bot] commented on PR #44263:
URL: https://github.com/apache/superset/pull/44263#issuecomment-5680521305
<!-- Bito Reply -->
The observation is correct. In the context of `build_query_dict` and the
subsequent resolution of temporal filters into `from_dttm` and `to_dttm` for
the `QueryObject`, the `rewrite_one_sided_time_range` flag does not affect
two-sided ranges. Since two-sided ranges are already fully defined by their
bounds, the internal logic that handles one-sided range rewriting is not
triggered, and the resulting `QueryObject` remains identical regardless of the
flag's value.
**tests/unit_tests/common/test_tabular_query.py**
```
query_dict = build_query_dict(
time_column="metric_time",
metrics=["revenue"],
dimensions=["metric_time"],
filters=[{"col": "product__product_name", "op": "==", "val":
"mel-bun"}],
time_range=time_range,
rewrite_one_sided_time_range=True, # the view path
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
