sadpandajoe commented on code in PR #44207:
URL: https://github.com/apache/superset/pull/44207#discussion_r4014731476
##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -281,6 +281,7 @@ Ask your admin for the MCP server URL and any
authentication tokens you need.
| `update_chart_preview` | Update a cached chart preview without saving
|
| `generate_explore_link` | Generate an Explore URL for interactive
visualization
|
| `delete_chart` | Delete a chart by ID or UUID (soft-deletes to
trash when `SOFT_DELETE` is enabled; fails if alerts/reports are still
attached, checked before editorship; otherwise returns `permission_denied` if
the caller isn't an editor of the chart — owners, Admins, and explicitly
granted editors qualify) |
+| `restore_chart` | Restore a soft-deleted chart from trash by ID or
UUID; not gated on `SOFT_DELETE`, so rows trashed while it was enabled stay
recoverable, but only soft-deleted charts can be restored — permanently deleted
charts are unrecoverable; returns `permission_denied` if the caller isn't an
editor of the chart |
Review Comment:
For objects outside the caller's RBAC visibility, both restore
implementations intentionally return `NotFound` instead of `permission_denied`,
so a client following these rows can misclassify a hidden but recoverable
object as permanently deleted. Should these descriptions reserve
`permission_denied` for visible non-editors and mention the `NotFound` case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
