bito-code-review[bot] commented on PR #44207: URL: https://github.com/apache/superset/pull/44207#issuecomment-5678939122
<!-- Bito Reply --> The current documentation for `restore_chart` and `restore_dashboard` states that they return `permission_denied` if the caller is not an editor. If the implementation actually returns `NotFound` for objects outside the caller's RBAC visibility, the documentation should be updated to accurately reflect this behavior. Reserving `permission_denied` for visible objects where the user lacks sufficient permissions and explicitly mentioning `NotFound` for objects that are hidden due to RBAC constraints would improve clarity for clients. **docs/docs/using-superset/using-ai-with-superset.mdx** ``` | `restore_chart` | Restore a soft-deleted chart from trash by ID or UUID; ...; returns `permission_denied` if the caller isn't an editor of the chart | | `restore_dashboard` | Restore a soft-deleted dashboard from trash by ID or UUID ...; returns `permission_denied` if the caller isn't an editor of the dashboard | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
