gabotorresruiz commented on code in PR #44173:
URL: https://github.com/apache/superset/pull/44173#discussion_r4019780809
##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -554,9 +555,15 @@ export class ThemeController {
* @param config - The complete theme configuration object
*/
public setThemeConfig(config: SupersetThemeConfig): void {
+ // Only a config that differs from the workspace default is an explicit
+ // override; an auto-forwarded default must not suppress the dashboard
theme.
+ const isExplicitOverride =
+ !isEqual(config.theme_default, this.defaultTheme) ||
+ !isEqual(config.theme_dark || null, this.darkTheme);
Review Comment:
Valid finding. Fixed: `setThemeConfig` now compares against a retained
workspace baseline (`workspaceDefaultTheme`/`workspaceDarkTheme`) rather than
the `defaultTheme`/`darkTheme` slots it reassigns, so a repeated identical
forward keeps `themeConfigOverride` set. Added a regression test that fails
against the old comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
