gabotorresruiz commented on PR #44173: URL: https://github.com/apache/superset/pull/44173#issuecomment-5687432209
Thanks @rebenitez1802, all addressed in the latest push. **Medium (baseline drift):** `setThemeConfig` now compares `config` against a retained workspace baseline (`workspaceDefaultTheme`/`workspaceDarkTheme`), captured at construction and kept in sync in `refreshSystemThemes`, instead of the mutable `defaultTheme`/`darkTheme` slots it reassigns just below. A repeated identical brand forward now stays an override. **Lows:** - Added `setThemeConfig keeps the override on a repeated identical brand forward` (fails against the old comparison). - Added `setThemeConfig flags an override when only theme_dark differs from the workspace default`, so the `theme_dark` clause is exercised in isolation (dropping that clause turns it red). - The comment now genuinely reads against the `workspace default`, since the comparison target is the retained baseline. Verified both new tests kill their mutants and the full `ThemeController.test.ts` suite is green (104 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
