aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5689514063
Independent final-readiness sweep at head
`a56733f76173cf699133c5204c18dfd7a515332c` — **all applicable CI is terminal
green.**
**Checks:** 86 pass, 12 skipped/neutral, **0 fail, 0 pending, 0 cancelled, 0
action-required.**
**Workflow runs at this exact SHA:** 25 total — 22 `completed/success`, 3
`completed/skipped`. No zero-job failures and no run left in progress.
**Base repair confirmed independently.** #44288 landed as `4c27cbd007`.
Recomputing the full migration graph from `origin/master`
(`6cfb33197444cbf74590c2803b6dcc06180439f4`) yields 388 revisions and **exactly
one head, `e2f3a1b9c640`**. All 15 jobs that previously failed on `Multiple
head revisions are present for given argument 'head'` now pass, including the
CLI, E2E, integration, Presto/Hive and `docker-build (dev)` jobs. No failure
was waived or suppressed.
**Rebase:** already applied cleanly onto the repaired base. Diff re-verified
intact — same 5 files, +48/−2, and no `superset/migrations/` files touched by
this PR. No further rebase is required: `mergeStateStatus` is `BLOCKED`, not
`BEHIND`, so an up-to-date branch is not a merge condition here.
**Review feedback:** 0 review threads and 0 formal reviews (confirmed via
GraphQL `reviewThreads.totalCount` / `reviews.totalCount`). Bito re-reviewed
the exact rebased range `a31aa6c..a56733f` and reported **0 actionable
suggestions**, with MyPy, Astral Ruff, Whispers and Detect-secrets all
successful. Nothing outstanding to address.
**Local revalidation on this head:** Pinot unit tests pass (7 passed, 3
skipped); `pinot = ["pinotdb[sqlalchemy]>=8.0.0, <10.0.0"]` intact; worktree
clean and local SHA matches the published head exactly.
Dependency claim remains verified directly against PyPI wheel metadata:
pinotdb `6.0.0`/`7.0.0` declare `sqlalchemy (>=1.4,<2)` under `extra ==
"sqlalchemy"`; `8.0.0` is the first release declaring `sqlalchemy (>=2.0,<3)`,
unchanged through `9.1.2`.
Standing limitation, restated rather than hidden:
`test_dialect_supports_installed_sqlalchemy` uses
`pytest.importorskip("pinotdb.sqlalchemy")`, and `pinotdb` is not in
`requirements/development.txt`, so that dependency-contract assertion skips
rather than executes in `unit-tests (current)`. This matches the existing
`tests/unit_tests/db_engine_specs/test_datastore.py` pattern; adding the driver
to dev requirements is deliberately out of scope for this PR.
**Only remaining gate is maintainer-only:** `reviewDecision:
REVIEW_REQUIRED`. @rusackas is already a requested reviewer.
**Exact human action:** a Superset committer reviews and approves this PR,
then merges it. No branch-side code, rebase or CI work remains.
PR remains OPEN, non-draft and mergeable. Nothing merged, nothing converted
to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
