krmmkr commented on code in PR #44216:
URL: https://github.com/apache/superset/pull/44216#discussion_r4022081283
##########
superset-frontend/src/dashboard/util/isValidChild.ts:
##########
@@ -65,6 +66,7 @@ const parentMaxDepthLookup: Record<string, Record<string,
number>> = {
[CHART_TYPE]: depthOne,
[DYNAMIC_TYPE]: depthOne,
[MARKDOWN_TYPE]: depthOne,
+ [FILTER_TYPE]: depthOne,
Review Comment:
Thanks! Added FILTER_TYPE to shouldWrapChildInRow under both
DASHBOARD_GRID_TYPE and TAB_TYPE. Dropping a filter onto the grid or a tab now
automatically wraps it in a ROW_TYPE, enabling horizontal resizing and
maintaining layout consistency with charts and markdown. Added unit test
coverage in newEntitiesFromDrop.test.ts and shouldWrapChildInRow.test.ts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
