etr2460 commented on a change in pull request #8633: Font styling consolidation URL: https://github.com/apache/incubator-superset/pull/8633#discussion_r350477261
########## File path: superset/assets/stylesheets/less/variables.less ########## @@ -122,4 +122,33 @@ /* Try to keep these to a minimum */ /************************************************************************/ @z-index-max: 1000; -@z-index-dropdown: 11; \ No newline at end of file +@z-index-dropdown: 11; + +/************************************************************************/ +/* TYPOGRAPHY */ +/* Commonly used font weights, line heights, etc. These should be the */ +/* core values used to build more complex styles for headers, etc. */ +/************************************************************************/ + +// Weights +@font-weight-light: 200; +@font-weight-normal: 400; +@font-weight-bold: 700; + +// Font Sizes +@font-size-base: 14px; // Base `rem` units on this, as needed. +// Ranged Sizes +@font-size-xxs: 9px; +@font-size-xs: 10px; +@font-size-s: 12px; // mapping 11px; +@font-size-m: @font-size-base; // maps to @font-size-base; for now +@font-size-l: 16px; +@font-size-xl: 21px; // mapping 20px, 24px when there's a 32 aboves it +@font-size-xxl: 28px; + +// Line Heights +@line-height-base: 1.4; +// Ranged Sizes +@line-height-tight: 1; +@line-height-normal: @line-height-base; +@line-height-loose: 2; Review comment: nit, add newline ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
