etr2460 commented on a change in pull request #8633: Font styling consolidation
URL:
https://github.com/apache/incubator-superset/pull/8633#discussion_r350476748
##########
File path: superset/assets/package.json
##########
@@ -17,7 +17,7 @@
"build": "cross-env NODE_OPTIONS=--max_old_space_size=8192
NODE_ENV=production webpack --mode=production --colors --progress",
"lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx . && tslint -c
tslint.json ./{src,spec}/**/*.ts{,x}",
"lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx . &&
tslint -c tslint.json --fix ./{src,spec}/**/*.ts{,x} && npm run clean-css",
- "clean-css": "prettier --write src/**/*.{css,less,sass,scss}",
+ "clean-css": "prettier --write 'src/**/*.{css,less,sass,scss}'",
Review comment:
does a linter catch if css isn't formatted properly with this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
