codeant-ai-for-open-source[bot] commented on code in PR #43070:
URL: https://github.com/apache/superset/pull/43070#discussion_r4028166381
##########
superset-frontend/src/core/dashboard/index.ts:
##########
@@ -53,4 +69,10 @@ export const dashboard: typeof dashboardApi = {
updateProps: provider.updateProps.bind(provider),
onDidLayoutChange: provider.onDidLayoutChange,
fetchQueryData,
+ // Both read per call rather than captured once: the canvas's scheme, the
+ // deployment's default and the light/dark theme can each change after this
+ // module is imported.
+ getCategoricalColors: () =>
+ CategoricalColorNamespace.getScale(canvasColorScheme()).colors,
+ getChartTheme: () => getChartTheme(themeObject.theme, canvasColorScheme()),
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag a theme-source mismatch between `themeObject.theme` and
`useTheme()` in the dashboard API; both are intentionally derived from the same
`Theme` instance and updated together.
**Applied to:**
- `superset-frontend/src/core/dashboard/index.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
