rusackas commented on code in PR #43070:
URL: https://github.com/apache/superset/pull/43070#discussion_r4028165674
##########
superset-frontend/src/core/dashboard/blocks/ChartBlock.tsx:
##########
@@ -223,20 +229,52 @@ export default function ChartBlock({ nodeId }: { nodeId:
string }) {
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [bindingKey]);
+ const colorScheme = provider.getRoot().props?.colorScheme;
+ const chartTheme = useMemo(
+ () =>
+ getChartTheme(
+ theme,
+ typeof colorScheme === 'string' ? colorScheme : undefined,
Review Comment:
This one's fixed too, same 7c236dc94e9 commit, now in ChartWidget.tsx
(renamed from ChartBlock along the way). Empty string normalizes to undefined
before it hits the scheme registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
