gabotorresruiz commented on code in PR #42539:
URL: https://github.com/apache/superset/pull/42539#discussion_r4030405838
##########
superset-frontend/src/hooks/apiResources/datasets.ts:
##########
@@ -125,10 +150,46 @@ export const useDatasetDrillInfo = (
const loadDrillByOptionsExtension = getExtensionsRegistry().get(
'load.drillby.options',
);
- let result;
+ let result: Dataset | undefined;
let labelSource;
- if (loadDrillByOptionsExtension && formData) {
+ if (
+ getDatasourceTypeFromDatasourceId(datasetId) ===
+ DatasourceType.SemanticView
+ ) {
+ // Semantic views short-circuit BEFORE the extension check: the
+ // extension receives only the numeric id, which would resolve
+ // the colliding regular dataset (sc-111089 review consensus).
+ // The structure payload carries no changed_on/owners metadata —
+ // those metadata-bar rows render their not-available state, an
+ // accepted degradation. Columns are narrowed to metadata needs;
+ // no drill flags are fabricated.
Review Comment:
Just a small NIT: this says `no drill flags are fabricated`, but
`semanticViewDimensionsToColumns` now sets `groupby: true`
(`src/utils/semanticViewStructure.ts:127`), and that is exactly the flag
`ChartContextMenu.tsx:241` reads to build `drillable_columns`. Worth a reword
so the next reader does not trust it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
