rusackas commented on PR #42539: URL: https://github.com/apache/superset/pull/42539#issuecomment-5719749202
@mikebridge before this merges I'd want aminghadersohi's thread on the untested call site addressed. They verified by reverting just that hunk that all 204 `FilterBar`/`GroupByFilterCard` tests still pass, so a semantic-view control could silently rebind to the colliding dataset after "Clear all" with nothing to catch it. There's also a few CodeAnt race-condition flags on `useDisplayControlDatasource`/`ColumnSelect` that haven't had a response yet, worth a look even if you end up disagreeing with them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
