aminghadersohi opened a new pull request, #44364:
URL: https://github.com/apache/superset/pull/44364

   ### SUMMARY
   
   `master` currently has **two alembic heads**, so `superset db upgrade` 
aborts before applying anything:
   
   ```
   ERROR [flask_migrate] Error: Multiple head revisions are present for given 
argument 'head';
   please specify a specific target revision, '<branchname>@head' to narrow to 
a specific head,
   or 'heads' for all heads
   ```
   
   The two heads are:
   
   | revision | down_revision |
   |---|---|
   | `e2f3a1b9c640` — merge purge-audit pruning and username index heads | 
`("c7f53d184ea2", "88a01c781622")` |
   | `0884f655c0a6` — merge task_dependencies with theme_editors heads | 
`("7e2c9a4f1b83", "aa5fa339627c")` |
   
   Neither is an ancestor of the other. The themes branch was long-lived and 
carried its own merge revisions, which were computed against a `master` that 
predated `e2f3a1b9c640`; merging it re-branched the graph.
   
   This PR adds a single empty merge revision (`60f94cd6cd11`) with 
`down_revision = ("0884f655c0a6", "e2f3a1b9c640")`. **There is no schema or 
data change** — `upgrade()` and `downgrade()` are empty. It mirrors the shape 
of the prior merge revision in `e2f3a1b9c640`.
   
   This unblocks integration CI repo-wide: every open PR's integration legs are 
dying in 1–2 minutes on this signature, before any tests run, including PRs 
that add no migrations at all.
   
   Note that the `enforce-single-migration-head` check does not catch this 
class of break, because it only inspects the migrations a PR itself adds. It 
passes green on PRs that are being broken by `master`'s divergent graph, so its 
status says nothing about whether `master`'s graph has converged.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — migration graph change only.
   
   ### TESTING INSTRUCTIONS
   
   Against a fresh SQLite metadata database:
   
   ```bash
   # Before this change
   $ superset db heads
   0884f655c0a6 (head)
   e2f3a1b9c640 (head)
   
   $ superset db upgrade
   ERROR [flask_migrate] Error: Multiple head revisions are present for given 
argument 'head' ...
   
   # After this change
   $ superset db heads
   60f94cd6cd11 (head)
   
   $ superset db upgrade
   INFO [alembic.runtime.migration] Running upgrade 0884f655c0a6, e2f3a1b9c640 
-> 60f94cd6cd11,
   Merge theme editors and purge audit heads.
   # completes successfully
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [x] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to