mikebridge commented on PR #44364: URL: https://github.com/apache/superset/pull/44364#issuecomment-5705962080
Reviewed `77ef39fcaaaf5170b8e828a69953a98ca4ca46f4` against `7b6dd7597c4af49f7f0571b7b33dd247f382218b` with Python, SQLAlchemy/Alembic, and Superset-committer lenses (automated review). **No blocking correctness findings from the Python and migration reviews.** The full migration graph has exactly the two expected parent heads before this change and only `60f94cd6cd11` afterward. Alembic 1.15.2 graph traversal confirms that starting from either parent still includes the missing other branch. Both empty callbacks are appropriate for this merge-only revision. One nonblocking typing nit at lines 26–27: under our strict assignment-annotation convention, prefer `revision: str` and `down_revision: tuple[str, str]`. The existing migration template emits unannotated identifiers, so this is not a correctness issue or a reason to hold up the repair. Verification limits: graph analysis and direct no-op callback execution, not an independently executed database upgrade/downgrade round trip. Please complete the migration checklist with actual downgrade verification and runtime/downtime evidence. At the final check, migration guards, SQLite integration, pre-commit and unit tests passed; MySQL/PostgreSQL integration were still running, with no failed checks observed. The committer lens therefore remained process-only under its CI-first rule, not a completed code approval. Required migration approvals and remaining CI still apply; this comment is not a substitute for maintainer approval. The merge-time guard improvement that would prevent recurrence can be handled separately from this focused repair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
