mikebridge commented on PR #44266: URL: https://github.com/apache/superset/pull/44266#issuecomment-5709007090
Follow-up at 52f018b3b12651d556f80a4dddd457a6d7d4578e on the three additional suggestions: - The default change is intentional and now disclosed in UPDATING.md as well as the PR/tool workflow: 25 metrics per page, dimensions opt-in, or discover them with get_compatible_dimensions. The agent instructions no longer promise inline dimensions on a default request. - The conservative fixed cap of 8 is retained deliberately. The operator-configured token guard is independent, and the guidance no longer presents the 25k default as universal. - The large fixture measures response-size/deduplication behavior; it is not per-metric compatibility proof. Separate existing tests cover that contract: test_list_metrics_external_per_metric_compatible_dimensions verifies differing results and exact selected-metric calls, and test_semantic_view_get_compatible_dimensions checks name-to-provider-object mapping. All are included in the 124 passing affected tests. Independent review also noted the pre-existing collection-before-pagination cost when embedding dimensions. That remains a nonblocking performance follow-up (resolve dimensions only for the selected page), not a dynamic-cap change or a claim of live-provider capacity testing. Fresh CI on this new head is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
