aminghadersohi commented on PR #44096: URL: https://github.com/apache/superset/pull/44096#issuecomment-5714030844
On the non-blocking ask about the screenshots: you're right that `db84fe4897` predates `10196a117d`, so what they show is the old eight-second toast. I could not re-run the live flow at head — this worktree has no running Superset or `superset-websocket` (`localhost:8088` and `localhost:8080` both refuse connections), and standing up the full realtime stack is more than the "if it is cheap" bar you set. Rather than leave the gap implicit, I've annotated it in the PR body: the screenshots are labelled as predating that commit, with the two behaviors that changed since spelled out, and a note that what they show of the applied and restored dashboard state is otherwise unchanged. The behavior changes themselves are covered by the unit tests you already exercised — `an actionable toast remains until it is explicitly dismissed`, and the Undo snapshot test that edits a filter after the notification and checks the edit survives while the untouched filter reverts. I've also added that edit-then-Undo case to the manual runbook in the testing instructions, so whoever next runs the live pass covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
