gabotorresruiz commented on PR #44096: URL: https://github.com/apache/superset/pull/44096#issuecomment-5688359548
Thanks @aminghadersohi for closing the loop on the live realtime + Undo validation, the screenshots and sequence in the validation comment are exactly what I was asking for. I also re-verified the delta since `db84fe4897` empirically: the rebase and master merges are content neutral (same file set, line for line), and the three review response fixes for Joe's comments check out. The backend suites pass at the reviewed head (87 tests), `test_required_time_range_cannot_be_cleared` correctly fails on the pre fix code, and the two new Undo tests fail pre fix as well, so they genuinely pin the fixes. Two small things before I approve: - The PR body still describes the eight second auto dismissing Undo toast in the SUMMARY, testing step 4, and the risk section; since actionable toasts now persist until dismissed, could you refresh those lines so the description matches the shipped behavior? - One test nit inline on `Toast.test.tsx`. CI wise you are already unblocked: your latest master merge picked up the alembic heads fix from #44288, and the required checks are re running now. The one shard that failed so far (`ReportModal.test.tsx` in jest shard 7) looks unrelated to this change. Once the run is green and the body is refreshed, this is ready for my approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
