bito-code-review[bot] commented on PR #44413:
URL: https://github.com/apache/superset/pull/44413#issuecomment-5724924813
<!-- Bito Reply -->
The flagged issue correctly identifies a potential risk where semantic
serialization exceptions are swallowed, which could lead to silent failures.
The PR already includes tests that address this, specifically
`test_dashboard_datasets_isolate_semantic_provider_failure` and
`test_dashboard_table_serialization_failure_is_not_suppressed`, which verify
that provider isolation does not swallow errors for tables or semantic views.
Since the PR already implements tests to ensure these errors are not
suppressed, the issue appears to be addressed by the existing changes. I
recommend verifying that the implementation code in
`superset/models/dashboard.py` (which was not fully visible in the provided
diff hunk) correctly implements the logic tested in these new test cases.
**superset/models/dashboard.py**
```
@pytest.mark.parametrize("error_type", [ValueError, RuntimeError])
def test_dashboard_datasets_isolate_semantic_provider_failure(
semantic_view: SemanticView,
error_type: type[Exception],
caplog: pytest.LogCaptureFixture,
) -> None:
"""A failed provider must not hide a mixed dashboard's table metadata."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
