mikebridge commented on PR #44413: URL: https://github.com/apache/superset/pull/44413#issuecomment-5735476864
Thanks @richardfogaca — addressed both access-boundary items from [your review](https://github.com/apache/superset/pull/44413#pullrequestreview-5251201094) in [a04fe1ef5805](https://github.com/apache/superset/commit/a04fe1ef5805fab1fdd8e6033d89138fae70c2a1). 1. Semantic views are checked before provider discovery; denied views return a minimal persisted-field stub. The real denial-path regression asserts zero provider instantiation/calls. It also caught discovery inside permission-error construction, which now reads the persisted datasource ID instead of datasource.data. 2. Both parent and semantic_view_features are removed for inaccessible callers and guest serialization. The narrowing assertions are flipped, with a real GuestUser schema case (not an HTTP token-acceptance claim). The backend-message precedence and independent real-datasource frontend regression are also corrected. Safe provider isolation/logging and the host id__type key remain unchanged. Scoped verification: 50 backend tests and 5 Chart tests passed; main MyPy and other applicable hooks passed. Independent exact-tree review found zero issues; source-resolved TypeScript passed with no diagnostics. The packaged-declaration hook failure was isolated to the missing-declaration environment; new-head CI remains the integration gate. Acknowledged the broad-catch trade-off and deferred embedded semantic support. [SC-121338](https://app.shortcut.com/preset/story/121338) is related provider validation-error mapping work, not full coverage of the discovery exception contract. Separate discovery-exception, typed guest-membership and shared host-key follow-ups are proposed in the handoff; no duplicate tickets or scope expansion in this repair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
