mikebridge commented on PR #44370: URL: https://github.com/apache/superset/pull/44370#issuecomment-5726057773
Browser walkthrough, step 4 (save as → reopen), now passes on a local stack running this branch (e4b9ffc4) plus #44416: - Legacy chart → **Start field selection** resets to `semantic_selection_version = cube-member-id-v1`, reselect a saved metric, Update chart → `POST /api/v1/chart/data` 200. - **Save as…** → `POST /api/v1/chart/` **201** (this was 422 `Datasource type is invalid` on master before #44416, which lifts the TABLE-only guard from #43500 for semantic views). - Fresh reload of the new chart: `semantic_selection_version` is present in both the Explore form data and the stored `params`, `datasource_type = semantic_view`, and the legacy "older identity format" panel does not render; the saved selection is carried by member ID, not display title. So steps 1–4 all pass, with the dependency that #44416 must land with or before this PR for the save path to work on a semantic view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
