bito-code-review[bot] commented on code in PR #44370:
URL: https://github.com/apache/superset/pull/44370#discussion_r4052635419
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -220,6 +220,7 @@ def _build_query_dict(
dimensions=request.dimensions,
filters=[{"col": f.col, "op": f.op, "val": f.val} for f in
request.filters],
time_range=request.time_range,
+ semantic_selection_version=request.semantic_selection_version,
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate for the local context. It correctly identifies
that a version mismatch should be handled as a client-side validation error
rather than an internal server error, allowing agents to recover by reselecting
member IDs.
**superset/mcp_service/semantic_layer/tool/get_table.py**
```
dimensions=request.dimensions,
filters=[{"col": f.col, "op": f.op, "val": f.val} for f in
request.filters],
time_range=request.time_range,
+ semantic_selection_version=request.semantic_selection_version,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
